Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Do not activate inspect if already active #28643

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(gatsby): Do not activate inspect if already active #28643

merged 1 commit into from
Dec 17, 2020

Conversation

connor4312
Copy link
Contributor

@connor4312 connor4312 commented Dec 15, 2020 •
edited
Loading

Description

Avoids activating the inspector if already active, which cases issues #26708

Documentation

The behavior to throw was introduced in response to nodejs/node#33012, where previously it just resulted in weird/broken behavior.

Related Issues

Fixes #26708

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2020
@LekoArts LekoArts added type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 16, 2020
LekoArts
LekoArts approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts changed the title fix(gatsby): Do not activate inspect if already active (#26708) fix(gatsby): Do not activate inspect if already active Dec 17, 2020
@LekoArts LekoArts merged commit f4e90b6 into gatsbyjs:master Dec 17, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby): Do not activate inspect if already active (gatsbyjs#28643)
759fb21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS Code debugger broken (Exception: Inspector is already activated)
2 participants
@connor4312 @LekoArts